Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement message bloc no cdt #1394

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

Viczei
Copy link
Contributor

@Viczei Viczei commented May 16, 2024

No description provided.

@Viczei Viczei linked an issue May 16, 2024 that may be closed by this pull request
@Viczei Viczei self-assigned this May 16, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -1,11 +1,17 @@
import { ContributionContentType } from "@socialgouv/cdtn-types";
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il faudrait ajouter les de cas de tests qu'on vient d'ajouter dans cette PR

Comment on lines 26 to +31
columns:
- content_agreement
- content_not_handled
- content_agreement_without_legal
- content_legal
- content_not_handled
- content_not_handled_without_legal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est dommage de faire ainsi.

On aurait pu avoir un seul content qui est une column en string qui est en html et ensuite avoir un type spécifique

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jun 4, 2024

🎉 Deployment for commit 6d2213b :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-6d2213bc8dd312dfced75fdcbcd4d6eb68befdb8
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-6d2213bc8dd312dfced75fdcbcd4d6eb68befdb8
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-6d2213bc8dd312dfced75fdcbcd4d6eb68befdb8
Debug

@@ -51,13 +51,16 @@ export async function generateContributions(

for (let i = 0; i < contributions.length; i++) {
const contrib = contributions[i];
const contribGeneric = contributions.find(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top

@Viczei Viczei merged commit 305cb46 into master Jun 4, 2024
30 checks passed
@Viczei Viczei deleted the linked-1374-messages-blocs-sans-code-du-travail branch June 4, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages blocs sans code du travail
4 participants