Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add withServiceMonitor #237

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

revolunet
Copy link
Member

@revolunet revolunet commented Oct 16, 2020

add app.withServiceMonitor that adds a prom monitor to /metrics (configurable)

@revolunet revolunet changed the base branch from master to beta October 16, 2020 13:55
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #237 (6d58002) into beta (b710bc4) will decrease coverage by 1.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #237      +/-   ##
==========================================
- Coverage   40.06%   38.74%   -1.33%     
==========================================
  Files          36       37       +1     
  Lines         292      302      +10     
  Branches       94       99       +5     
==========================================
  Hits          117      117              
- Misses        161      171      +10     
  Partials       14       14              
Impacted Files Coverage Δ
src/components/app/index.ts 0.00% <0.00%> (ø)
src/utils/getServiceMonitor.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b710bc4...6d58002. Read the comment docs.

@revolunet revolunet marked this pull request as ready for review October 20, 2020 21:12
@revolunet
Copy link
Member Author

later

@revolunet revolunet closed this Nov 6, 2020
@revolunet
Copy link
Member Author

should also add an exclusion in the ingress rule :

annotations:
  nginx.ingress.kubernetes.io/configuration-snippet: |
    location /metrics {
      deny all;
      return 403;
    }

@revolunet revolunet reopened this Nov 23, 2020
@revolunet revolunet changed the title Feat with service monitor WIP: Feat with service monitor Nov 23, 2020
@revolunet revolunet changed the title WIP: Feat with service monitor WIP: add withServiceMonitor Nov 23, 2020
@revolunet revolunet changed the title WIP: add withServiceMonitor WIP: feat: add withServiceMonitor Nov 23, 2020
Base automatically changed from beta to alpha November 23, 2020 12:43
@douglasduteil
Copy link
Contributor

Needs rebase

Base automatically changed from alpha to master December 11, 2020 17:24
@douglasduteil douglasduteil marked this pull request as draft July 16, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants