New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: add withServiceMonitor #237
Draft
revolunet
wants to merge
3
commits into
master
Choose a base branch
from
feat-withServiceMonitor
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #237 +/- ##
==========================================
- Coverage 40.06% 38.74% -1.33%
==========================================
Files 36 37 +1
Lines 292 302 +10
Branches 94 99 +5
==========================================
Hits 117 117
- Misses 161 171 +10
Partials 14 14
Continue to review full report at Codecov.
|
later |
should also add an exclusion in the ingress rule : annotations:
nginx.ingress.kubernetes.io/configuration-snippet: |
location /metrics {
deny all;
return 403;
} |
revolunet
changed the title
WIP: add withServiceMonitor
WIP: feat: add withServiceMonitor
Nov 23, 2020
Needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
app.withServiceMonitor
that adds a prom monitor to/metrics
(configurable)