Add support for lcobucci/jwt 5.0 #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atymic
reviewed
Apr 29, 2023
| @@ -40,7 +40,8 @@ | |||
| "ext-json": "*", | |||
| "ext-openssl": "*", | |||
| "firebase/php-jwt": "^6.2", | |||
| "lcobucci/jwt": "^4.1.5", | |||
| "lcobucci/clock": "^2.0 || ^3.0", | |||
| "lcobucci/jwt": "^4.1.5 || ^5.0.0", | |||
There was a problem hiding this comment.
Are there any breaking changes here?
There was a problem hiding this comment.
Here is list of all official BC-break changes of lcobucci/jwt for upgrate from v.4 to v.5:
- 979: Builder: make it immutable
- 939: Remove empty Signer, empty Key, empty Signature, empty strings
- 937: Remove \Lcobucci\JWT\Signer\None
- 873: Use abstraction instead of concretion
- 872: Remove deprecated components
- 871: Require PHP 8.1+
- 969: 4.3.x merge up into 5.0.x
Minimum PHP for v.5 is 8.1, that's why I kept using the older version as well "^4.1.5 || ^5.0.0", but functionality in this package is compatible with both versions.
atymic
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.