Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduced how often collect cycles is called #80

Merged

Conversation

clinuxrulz
Copy link
Collaborator

regards #77

@clinuxrulz
Copy link
Collaborator Author

Note: jest is only working on an older version of node at the moment.
jestjs/jest#8069

So you can ignore the jest errors, all tests pass here.

@clinuxrulz
Copy link
Collaborator Author

clinuxrulz commented Mar 16, 2019

Hold off merging this one. Problem still not resolved when I trial this code. I'm going to investigate some more.

@clinuxrulz
Copy link
Collaborator Author

clinuxrulz commented Mar 16, 2019

This PR is all good. I did some further investigation and it was actually calling collectCycles just once per transaction at most (less than once per transaction if no decrements occur). It was just the nature of the code I've written for that incremental update of three.js code, there are transactions occurring in that code when wiring up independent parts to the actual scene giving the illusion of many collectCycles in one transaction, when in fact it was one collectCycles in each of many transactions. (The 3d model construction code was passing over an asynchronous boundary, for use such as fetching the textures for the model causing many transactions.)

@the-real-blackh the-real-blackh merged commit bd14e2b into SodiumFRP:master Mar 18, 2019
@the-real-blackh
Copy link

Are you missing some commit privileges?

@clinuxrulz
Copy link
Collaborator Author

No. I just like having a 2nd set of eyes to review what I do, just in case I make a mistake.

@clinuxrulz
Copy link
Collaborator Author

In the Travis log file I can see:
"Skipping a deployment with the npm provider because this is not a tagged commit"

Does that mean someone here has done CI? And we just need to tag the commit in order to get a new version on npm?

@clinuxrulz clinuxrulz deleted the collect-cycles-performance branch June 2, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants