Upgrade typescript-eslint to 2.5.0 #1571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
changed the title
| @@ -2,10 +2,4 @@ | |||
| 'emission:src/lib/containers/gene.tsx':[ | |||
| 78, | |||
| ], | |||
| 'emission:src/lib/containers/home.tsx':[ | |||
| 35, | |||
There was a problem hiding this comment.
optional properties are ignored now. See typescript-eslint/typescript-eslint#918
vilchik-elena
changed the title
|
Before continuing this effort, we should consider updating to 2.3.2 instead, since it contains a useful fix for |
yassin-kammoun-sonarsource
force-pushed
the
upgrade-typescript-eslint
branch
from
4c20a77
to
02128c9
Compare
yassin-kammoun-sonarsource
changed the title
yassin-kammoun-sonarsource
force-pushed
the
upgrade-typescript-eslint
branch
from
02128c9
to
45b4399
Compare
yassin-kammoun-sonarsource
changed the title
yassin-kammoun-sonarsource
force-pushed
the
upgrade-typescript-eslint
branch
from
45b4399
to
b1dbc62
Compare
|
Replaced by #1702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
prefer-readonly) looks like issues with properties of array or object type are excluded nowno-inferrable-types), FPs removed, see fix(eslint-plugin): [no-inferrable-types] ignore optional properties typescript-eslint/typescript-eslint#918