Fixes no-unused-collections on exported members (#197)

SonarSource · Jun 30, 2021 · a91e540 · a91e540
1 parent 345151b
commit a91e540
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/rules/no-unused-collection.ts b/src/rules/no-unused-collection.ts
@@ -61,7 +61,26 @@ function collectUnusedCollections(
   });
 }
 
+// Determines if a given variable is being exported from a module.
+function isExported(variable: TSESLint.Scope.Variable) {
+  const definition = variable.defs[0] as TSESLint.Scope.Definition;
+
+  if (definition) {
+    let {node} = definition;
+    if (node.type === "VariableDeclarator") {
+        node = node.parent;
+    } else if (definition.type === "Parameter") {
+        return false;
+    }
+    return node.parent.type.indexOf("Export") === 0;
+  }
+  return false;
+}
+
 function isUnusedCollection(variable: TSESLint.Scope.Variable) {
+  if(isExported(variable)){
+    return false;
+  }
   if (variable.references.length <= 1) {
     return false;
   }

diff --git a/tests/rules/no-unused-collection.test.ts b/tests/rules/no-unused-collection.test.ts
@@ -160,6 +160,16 @@ ruleTester.run('Primitive return types should be used.', rule, {
           console.log(i);
         }`,
     },
+    {
+      code: `
+        export const array = [];
+
+        array.push(1);
+      `,
+    },
+    {
+      code: `export const collection = new Map()`,
+    },
   ],
   invalid: [
     {