Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: Template literals should not be nested #63

Closed
stas-vilchik opened this issue Apr 27, 2018 · 5 comments · Fixed by #233
Closed

Rule: Template literals should not be nested #63

stas-vilchik opened this issue Apr 27, 2018 · 5 comments · Fixed by #233
Assignees
Labels
Milestone

Comments

@stas-vilchik
Copy link
Contributor

let color = "red";
let number = 3;
let message = `I have ${color ? `${color} ${number}` : number} apples`;
//                              ^^^^^^^^^^^^^^^^^^^^ do not use nested string templates
@vilchik-elena vilchik-elena added this to the 0.6.0 milestone Feb 14, 2020
@kevinsmithwebdev-zz
Copy link

Hello, I am a little new to open source and am not sure how to jump in. I've written some linter rules at work. I see that this is open. I also see that there is a link to code in the SonarJS repo. Are you looking for someone to adapt the existing code in SonarJS to this repo? May I give it a go?

@vilchik-elena
Copy link
Contributor

@kevinsmithwebdev yep, go for that
the idea is to copy-paste the implementation from SonarJS

@kevinsmithwebdev-zz
Copy link

Great, I'll hop on it then, thanx.

@kevinsmithwebdev-zz
Copy link

Was there something else I needed to do? I thought I'd done the right steps.

@saberduck saberduck removed this from the 0.6.0 milestone Apr 29, 2021
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added this to the 0.9.0 milestone Jun 28, 2021
@vilchik-elena vilchik-elena changed the title Rule: Avoid nested string templates Rule: Template literals should not be nested Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment