added no-nested-template-literals rule #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @kevinsmithwebdev, sorry we didn't process your PR. In the meanwhile this was implemented in #233 |
|
... which is why I won't bother wasting my time contributing to your project.It's a shame - I wanted to find a pet project to which to contribute. But that PR sat there for over a year. If you have that little respect for your contributors, then I guess I need to find somewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Pulled in the code from the other repo and adapted it. no-nested-template-literals
I haven't worked in this repo before, haven't done a lot of open source, and am not comfortable with the github PR flow - so please don't hesitate to tell me if I've done something incorrectly.
I notice I've updated the yarn.lock. Please let me know if I need to revert it. ADDENDUM - Nevermind, travis seemed to make it clear that that was a no-no - reverted.