Rule S2589: Boolean expressions should not be gratuitous #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
issue-149
branch
3 times, most recently
from
3be4244
to
47518bb
Compare
yassin-kammoun-sonarsource
force-pushed
the
issue-149
branch
from
47518bb
to
858cbcc
Compare
vilchik-elena
approved these changes
Jun 30, 2021
| @@ -30,6 +30,7 @@ Code Smells, or maintainability issues, are raised for places of code which migh | |||
| * String literals should not be duplicated ([`no-duplicate-string`]) | |||
| * Two branches in a conditional structure should not have exactly the same implementation ([`no-duplicated-branches`]) | |||
| * Functions should not have identical implementations ([`no-identical-functions`]) | |||
| * Boolean expressions should not be gratuitous ([`no-gratuitous-expressions`]) | |||
There was a problem hiding this comment.
I think those should be sorted by rule key
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149