Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S4158: Empty collections should not be accessed or iterated #232

Merged
merged 2 commits into from Jun 29, 2021
Merged

Rule S4158: Empty collections should not be accessed or iterated #232

merged 2 commits into from Jun 29, 2021

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #151

saberduck
saberduck approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@saberduck saberduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to change the types from eslint to @typescript-eslint

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.1% 96.1% Coverage
0.0% 0.0% Duplication

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 87d2bc1 into master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saberduck saberduck saberduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule S4158: Empty collections should not be accessed or iterated
2 participants
@yassin-kammoun-sonarsource @saberduck