Rule S930: improve highlighting for no-extra-arguments #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual Excess parameters are now highlighted as secondary locations. The primary location is therefore reduced to the callee expression.
vilchik-elena
requested changes
Jul 1, 2021
src/rules/no-extra-arguments.ts
Outdated
| // find actual extra arguments to highlight | ||
| callExpr.arguments.forEach((argument, index) => { | ||
| if (index >= paramLength) { | ||
| secondaryLocations.push(issueLocation(argument.loc, argument.loc, 'Extra argument')); |
There was a problem hiding this comment.
toSecondaryLocation seems better here
| ]), | ||
| }, | ||
| ], | ||
| options: ['sonar-runtime'], | ||
| }, | ||
| { |
There was a problem hiding this comment.
why those 2 new tests?
There was a problem hiding this comment.
The contributor probably wanted to demonstrate that the rule also works with the special arguments object. Since it's unrelated to the ticket, I will drop those.
| ], | ||
| }, | ||
| { | ||
| code: ` | ||
| function foo(p1, p2) {} | ||
| // ^^^^^^> | ||
| foo(1, 2, 3); | ||
| //^^^^^^^^^^^^ | ||
| //^^^ ^ |
There was a problem hiding this comment.
should be //^^^ <^ to show that second piece is a secondary location
|
Kudos, SonarCloud Quality Gate passed! |
vilchik-elena
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
The ticket mentions customising the message of the primary location with the function name depending on the callee type, which this user contribution does not include. I think we don't need to go that far as the location-based highlighting of an issue would be enough.