Improve S3776: Exclude complexity of JSX short-circuits #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoismora
force-pushed
the
issue-3289-cognitive-complexity-jsx-short-circuits
branch
from
c234a0c
to
29bd2b1
Compare
|
As discussed, the rule checks that the short-circuit logical expression doesn't have a ternary operator at its right-hand side before deciding to exclude it from the cognitive complexity computation. |
added 2 commits
November 30, 2022 17:32
… JSXExpressionContainer
ilia-kebets-sonarsource
approved these changes
Dec 2, 2022
|
Kudos, SonarCloud Quality Gate passed! |
saberduck
deleted the
issue-3289-cognitive-complexity-jsx-short-circuits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SonarSource/SonarJS#3289