Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify S1862 (no-identical-conditions): Detect duplicated condition overlaps #394

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Modify S1862 (no-identical-conditions): Detect duplicated condition overlaps #394

merged 1 commit into from
Mar 16, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.4% 69.4% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.2% 94.2% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.2% 94.2% Coverage
0.0% 0.0% Duplication

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 4dfd992 into master Mar 16, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource deleted the sonarjs/i3696 branch March 16, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify S1862 (no-identical-conditions): Detect duplicated condition overlaps
2 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource