Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S2428 (prefer-object-literal): Ignore circular reference assignments #427

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix FP S2428 (prefer-object-literal): Ignore circular reference assignments #427

merged 2 commits into from
Nov 3, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #391

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Fix FP prefer-object-literal: Ignore circular reference assignments Fix FP S2428 (prefer-object-literal): Ignore circular reference assignments Nov 2, 2023
ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion, otherwise LGTM!

@yassin-kammoun-sonarsource @ilia-kebets-sonarsource
Update src/rules/prefer-object-literal.ts
1f1d279 
Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 7808c0d into master Nov 3, 2023
5 checks passed
peterjokumsen added a commit to helderberg-pirates-baseball/websites that referenced this pull request Nov 7, 2023
@peterjokumsen @renovate-bot
chore(deps): ⬆️ update tooling (#75)
2c98f3c 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [eslint](https://eslint.org)
([source](https://togithub.com/eslint/eslint)) | [`~8.52.0` ->
`~8.53.0`](https://renovatebot.com/diffs/npm/eslint/8.52.0/8.53.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint/8.52.0/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint/8.52.0/8.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`0.21.0` ->
`0.23.0`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.21.0/0.23.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.21.0/0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.21.0/0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>eslint/eslint (eslint)</summary>

### [`v8.53.0`](https://togithub.com/eslint/eslint/releases/tag/v8.53.0)

[Compare
Source](https://togithub.com/eslint/eslint/compare/v8.52.0...v8.53.0)

#### Features

-
[`528e1c0`](https://togithub.com/eslint/eslint/commit/528e1c00dc2aa8636e5b706c4270dc655cfa17e3)
feat: Deprecate formatting rules
([#&#8203;17696](https://togithub.com/eslint/eslint/issues/17696))
(Nicholas C. Zakas)
-
[`c0b11dd`](https://togithub.com/eslint/eslint/commit/c0b11ddb9f8aacc64c3933b9f278939aa7bea481)
feat: Add suggestions for no-prototype-builtins
([#&#8203;17677](https://togithub.com/eslint/eslint/issues/17677))
(Yonathan Randolph)

#### Bug Fixes

-
[`1ad6257`](https://togithub.com/eslint/eslint/commit/1ad6257744d63281235fcc33288394b1d69b34ce)
fix: ensure that exit code for fatal errors is not overwritten
([#&#8203;17683](https://togithub.com/eslint/eslint/issues/17683))
(Milos Djermanovic)
-
[`b329ea7`](https://togithub.com/eslint/eslint/commit/b329ea748dff45f11c7e218208244dc24fcb5c8f)
fix: add `;` after JSX nodes in `no-object-constructor` autofix
([#&#8203;17672](https://togithub.com/eslint/eslint/issues/17672))
(Francesco Trotta)

#### Documentation

-
[`ab8c60d`](https://togithub.com/eslint/eslint/commit/ab8c60d4f859cec787b5a12f7271b40e666235f5)
docs: change position of return to top button
([#&#8203;17688](https://togithub.com/eslint/eslint/issues/17688))
(Tanuj Kanti)
-
[`4fc44c0`](https://togithub.com/eslint/eslint/commit/4fc44c0b8c5dca466bffdfe01dfd80794d7762b7)
docs: update twitter icon to new X icon
([#&#8203;17687](https://togithub.com/eslint/eslint/issues/17687))
(Tanuj Kanti)
-
[`4164b2c`](https://togithub.com/eslint/eslint/commit/4164b2ceec89726b18ea0b0e34fab05735d55a09)
docs: Update README (GitHub Actions Bot)
-
[`8651895`](https://togithub.com/eslint/eslint/commit/8651895ca7ae15e13d74c8be67d9eebd63a7ce1f)
docs: Fix tabs in rule examples
([#&#8203;17653](https://togithub.com/eslint/eslint/issues/17653))
(Francesco Trotta)
-
[`3aec1c5`](https://togithub.com/eslint/eslint/commit/3aec1c55ba2c6d2833e1c0afe0a58f0cc6bbc0a4)
docs: explained rule fixers and suggestions
([#&#8203;17657](https://togithub.com/eslint/eslint/issues/17657)) (Josh
Goldberg ✨)

#### Chores

-
[`ba4d4d5`](https://togithub.com/eslint/eslint/commit/ba4d4d567a82554250dd8c7933322824e6a73944)
chore: remove metascraper
([#&#8203;17707](https://togithub.com/eslint/eslint/issues/17707))
(Milos Djermanovic)
-
[`0d07338`](https://togithub.com/eslint/eslint/commit/0d0733882944b4849d71a40723c251213698cef9)
chore: Update dependencies
([#&#8203;17706](https://togithub.com/eslint/eslint/issues/17706))
(Milos Djermanovic)
-
[`93256a3`](https://togithub.com/eslint/eslint/commit/93256a32e312f3f4e5c532762df71bdc06bded20)
chore: package.json update for
[@&#8203;eslint/js](https://togithub.com/eslint/js) release (ESLint
Jenkins)
-
[`485ec7d`](https://togithub.com/eslint/eslint/commit/485ec7d08ed2040c292f52bf9b9152f6c8ef4809)
test: fix ESLint tests for caching
([#&#8203;17699](https://togithub.com/eslint/eslint/issues/17699))
(Milos Djermanovic)
-
[`db06a7f`](https://togithub.com/eslint/eslint/commit/db06a7ff7992a74368f03d1f21beb00df0407021)
ci: bump actions/setup-node from 3 to 4
([#&#8203;17676](https://togithub.com/eslint/eslint/issues/17676))
(dependabot\[bot])
-
[`994596b`](https://togithub.com/eslint/eslint/commit/994596b07f5ff20a615a4be1ea03e5fd59cdb84b)
ci: run tests in Node.js 21
([#&#8203;17673](https://togithub.com/eslint/eslint/issues/17673))
(Francesco Trotta)

</details>

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v0.23.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/0.23.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.22.0...0.23.0)

#### What's Changed

- Prepare for next iteration by
[@&#8203;ilia-kebets-sonarsource](https://togithub.com/ilia-kebets-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#425
- Update own dependency by
[@&#8203;ilia-kebets-sonarsource](https://togithub.com/ilia-kebets-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#426
- Fix FP S2428 (`prefer-object-literal`): Ignore circular reference
assignments by
[@&#8203;yassin-kammoun-sonarsource](https://togithub.com/yassin-kammoun-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#427
- Update license to `LGPL-3.0-only` by
[@&#8203;ilia-kebets-sonarsource](https://togithub.com/ilia-kebets-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#428

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.22.0...0.23.0

###
[`v0.22.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/0.22.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.21.0...0.22.0)

#### What's Changed

-   Update vulnerable dependencies

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.21.0...0.22.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NC4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Renovate Bot GitHub <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S2428 (prefer-object-literal): Ignore circular reference assignments
2 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource