Migrate to all newest packages, except for eslint v9 #460

zglicz · 2024-04-24T09:06:25Z

zglicz · 2024-04-24T09:08:17Z

package.json

@@ -1,6 +1,6 @@
 {
  "name": "eslint-plugin-sonarjs",
-  "version": "0.25.1",
+  "version": "0.26.0",


I didn't land this version pull after the last release (#455)

zglicz · 2024-04-24T09:09:05Z

tsconfig.json

@@ -10,7 +10,8 @@
    "allowSyntheticDefaultImports": true,
    "noEmit": false,
    "outDir": "lib",
-    "sourceMap": true
+    "sourceMap": true,
+    "moduleResolution": "nodenext"


This is required to allow for the typescript-eslint libs to work. See more details - typescript-eslint/typescript-eslint#7284

zglicz · 2024-04-24T09:10:03Z

tests/rule-tester.ts

-import { ESLintUtils } from '@typescript-eslint/utils';
-
-const { RuleTester } = ESLintUtils;
+import { RuleTester } from '@typescript-eslint/rule-tester';


Breaking change, now lives in a separate package - https://typescript-eslint.io/packages/rule-tester/

package-lock.json

zglicz · 2024-04-24T14:17:48Z

tests/index.test.ts

@@ -29,6 +29,7 @@ it('should declare all rules in recommended config', () => {
    expect(configs.recommended.rules).toHaveProperty(`sonarjs/${rule}`);
  });
  expect(Object.keys(configs.recommended.rules!)).toHaveLength(existingRules.length);
+  expect(new Set(Object.values(configs.recommended.rules!))).toEqual(new Set(['off', 'error']));


I added this check, as I would have missed almost exporting "recommended"

zglicz · 2024-04-24T14:18:52Z

src/rules/cognitive-complexity.ts

@@ -61,13 +62,13 @@ const rule: TSESLint.RuleModule<string, (number | 'metric' | 'sonar-runtime')[]>
    type: 'suggestion',
    docs: {
      description: 'Cognitive Complexity of functions should not be too high',
-      recommended: 'error',


omitting this value, implies it's not recommended to be turned on. And also, based on this value, we compile our plugin.

sonarcloud · 2024-04-25T10:23:06Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
98.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

zglicz

PR should be ready for review. SonarCloud analysis is passing, no more deprecated API's, tests passing and the build issue is unrelated and tracked in: https://sonarsource.atlassian.net/issues/BUILD-4777?jql=ORDER%20BY%20created%20DESC

zglicz · 2024-04-25T12:56:35Z

.cirrus.yml

@@ -30,7 +30,7 @@ build_task:
    <<: *CONTAINER_DEFINITION
    docker_arguments:
      CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
-    cpu: 3
+    cpu: 1


running jest with --runInBand so we don't need more than 1 core

zglicz · 2024-04-25T12:57:08Z

ruling/index.ts

@@ -20,8 +20,8 @@
 import * as fs from 'fs';
 import * as path from 'path';
 import { ESLint } from 'eslint';
-import * as lodash from 'lodash';
-import * as minimist from 'minimist';
+import lodash from 'lodash';


the change of moduleResolution: "nodenext" requires we change this.

ericmorand-sonarsource · 2024-04-25T13:13:19Z

Looks good to me: tests pass locally and build succeeds. As soon as the CI is fixed we can merge IMHO.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs) | [`0.25.1` -> `1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SonarSource/eslint-plugin-sonarjs (eslint-plugin-sonarjs)</summary> ### [`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...004d7944672f249000e1eb1c97acd13e31e455eb) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3) ### [`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2) #### What's Changed - Export "meta" for plugin by [@zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#472 ### [`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0) Eslint-plugin-sonarjs is compatible with ESLint v9. ##### What's Changed - Migrate to all newest packages, except for eslint v9 by [@zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#460 - Move from a compile-all to a compile-entry-point pattern by [@ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#463 - ESLINTJS-36 Split out tests and analyze into separate steps by [@zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#465 - Fix breaking no-one-iteration-loop after ESLint v9 breaking change by [@zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#467 - Resolve ESLINTJS-37 by [@ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#466 - Add ruling tests to handle eslint 8 and 9 by [@zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#468 - Make the exported rules a typed record by [@ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#469 **Full Changelog**: SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ScaleLeap/amazon-marketplaces).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Migrate to newest typescript-eslint packages

8c6f1f4

zglicz requested a review from ericmorand-sonarsource April 24, 2024 09:06

zglicz added 2 commits April 24, 2024 11:17

Make build work

2fe6f64

Add strict to if/else and cognitive complexity rules

b47593a

zglicz commented Apr 24, 2024

View reviewed changes

ericmorand-sonarsource reviewed Apr 24, 2024

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

zglicz added 2 commits April 24, 2024 11:38

update packge-lock.json with npm registry links

6d089a7

Export plugin in eslint v9 format

b3b9741

zglicz commented Apr 24, 2024

View reviewed changes

zglicz added 5 commits April 24, 2024 16:50

Stop using deprecated method

91fcc2a

Fixup parser logic

c3b2c93

increase memory

47660e8

More deprecated methods

92fb1c7

Fixup last sonar issues

d600aaf

zglicz commented Apr 25, 2024

View reviewed changes

ericmorand-sonarsource approved these changes Apr 25, 2024

View reviewed changes

zglicz merged commit 67ca4c5 into master Apr 25, 2024
2 of 6 checks passed

zglicz deleted the new_packages branch April 25, 2024 13:33

zglicz added this to the 1.0.0 milestone May 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to all newest packages, except for eslint v9 #460

Migrate to all newest packages, except for eslint v9 #460

zglicz commented Apr 24, 2024 •

edited by ericmorand-sonarsource

zglicz Apr 24, 2024

zglicz Apr 24, 2024

zglicz Apr 24, 2024

zglicz Apr 24, 2024

zglicz Apr 24, 2024

sonarcloud bot commented Apr 25, 2024

zglicz left a comment

zglicz Apr 25, 2024

zglicz Apr 25, 2024

ericmorand-sonarsource commented Apr 25, 2024

Migrate to all newest packages, except for eslint v9 #460

Migrate to all newest packages, except for eslint v9 #460

Conversation

zglicz commented Apr 24, 2024 • edited by ericmorand-sonarsource

zglicz Apr 24, 2024

Choose a reason for hiding this comment

zglicz Apr 24, 2024

Choose a reason for hiding this comment

zglicz Apr 24, 2024

Choose a reason for hiding this comment

zglicz Apr 24, 2024

Choose a reason for hiding this comment

zglicz Apr 24, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Apr 25, 2024

Quality Gate passed

zglicz left a comment

Choose a reason for hiding this comment

zglicz Apr 25, 2024

Choose a reason for hiding this comment

zglicz Apr 25, 2024

Choose a reason for hiding this comment

ericmorand-sonarsource commented Apr 25, 2024

zglicz commented Apr 24, 2024 •

edited by ericmorand-sonarsource