Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLINTJS-36 Split out tests and analyze into separate steps #465

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Apr 29, 2024

Reworked a bit how the tasks work. Here is a short summary

  • build - copy repo and build
  • test_and_analyze - after build, run unit-tests and sonarscanner based on the test run output
  • publish - after build, upload the package to repox
  • qa (unchanged) - full ruling tests, currently running with 3 different node versions 16, 18 and 20.
  • ws (White Source, currently Mend.io) - I assume this is for compliance

@zglicz zglicz marked this pull request as ready for review April 29, 2024 13:48
@zglicz zglicz changed the title Split out tests and analyze into separate steps ESLINTJS-36 Split out tests and analyze into separate steps Apr 29, 2024
@zglicz zglicz enabled auto-merge (squash) April 29, 2024 13:59
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zglicz zglicz merged commit 7ef1a01 into master Apr 30, 2024
8 checks passed
@zglicz zglicz deleted the split_ci branch April 30, 2024 10:11
@zglicz zglicz added this to the 1.0.0 milestone May 3, 2024
renovate bot added a commit to ScaleLeap/amazon-marketplaces that referenced this pull request May 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`0.25.1` ->
`1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...004d7944672f249000e1eb1c97acd13e31e455eb)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3)

###
[`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2)

#### What's Changed

- Export "meta" for plugin by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#472

###
[`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0)

Eslint-plugin-sonarjs is compatible with ESLint v9.

##### What's Changed

- Migrate to all newest packages, except for eslint v9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#460
- Move from a compile-all to a compile-entry-point pattern by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#463
- ESLINTJS-36 Split out tests and analyze into separate steps by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#465
- Fix breaking no-one-iteration-loop after ESLint v9 breaking change by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#467
- Resolve ESLINTJS-37 by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#466
- Add ruling tests to handle eslint 8 and 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#468
- Make the exported rules a typed record by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#469

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ScaleLeap/amazon-marketplaces).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsicmVub3ZhdGVib3QiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants