Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking no-one-iteration-loop after ESLint v9 breaking change #467

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Apr 30, 2024

Fixes ESLINTJS-44

As described in eslint/eslint#17457, CodePath#currentSegments is now removed. Fixing this following, the suggested implementation of the extraction of the currentSegment.

Copy link

sonarcloud bot commented Apr 30, 2024

Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@zglicz zglicz merged commit a857635 into master Apr 30, 2024
6 checks passed
@zglicz zglicz deleted the fix-no-one-iteration branch April 30, 2024 13:48
@zglicz zglicz added this to the 1.0.0 milestone May 3, 2024
renovate bot added a commit to ScaleLeap/amazon-marketplaces that referenced this pull request May 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`0.25.1` ->
`1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...004d7944672f249000e1eb1c97acd13e31e455eb)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3)

###
[`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2)

#### What's Changed

- Export "meta" for plugin by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#472

###
[`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0)

Eslint-plugin-sonarjs is compatible with ESLint v9.

##### What's Changed

- Migrate to all newest packages, except for eslint v9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#460
- Move from a compile-all to a compile-entry-point pattern by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#463
- ESLINTJS-36 Split out tests and analyze into separate steps by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#465
- Fix breaking no-one-iteration-loop after ESLint v9 breaking change by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#467
- Resolve ESLINTJS-37 by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#466
- Add ruling tests to handle eslint 8 and 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[SonarSource/eslint-plugin-sonarjs#468
- Make the exported rules a typed record by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[SonarSource/eslint-plugin-sonarjs#469

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ScaleLeap/amazon-marketplaces).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsicmVub3ZhdGVib3QiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants