Add ruling tests to handle eslint 8 and 9 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zglicz
commented
May 1, 2024
| @@ -87,6 +87,34 @@ qa_task: | |||
| - jfrog rt npm-config --repo-resolve npm --repo-deploy sonarsource-npm-public-qa | |||
| - git submodule update --init --depth 1 -r | |||
| - jfrog rt npm-ci | |||
| - npm install eslint-ruling@npm:eslint@8.57.0 | |||
There was a problem hiding this comment.
this should be a no-op, but just to be explicit, let us make sure it is running eslint8
| - build | ||
| eks_container: | ||
| matrix: | ||
| - docker_arguments: |
There was a problem hiding this comment.
here we remove the test on Nodev16 (that we perform with eslint8), as eslint9 requires Nodev18.18
| @@ -44,6 +44,7 @@ | |||
| "@babel/preset-flow": "7.24.1", | |||
| "@babel/preset-react": "7.24.1", | |||
| "@types/eslint": "8.56.10", | |||
| "@types/eslint-ruling": "npm:@types/eslint@^8.56.10", | |||
There was a problem hiding this comment.
sadly, there are no types for eslint9
| @@ -0,0 +1,13 @@ | |||
| declare module '@babel/eslint-parser' { | |||
There was a problem hiding this comment.
|
ericmorand-sonarsource
approved these changes
May 2, 2024
renovate bot
added a commit
to ScaleLeap/amazon-marketplaces
that referenced
this pull request
May 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs) | [`0.25.1` -> `1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>SonarSource/eslint-plugin-sonarjs (eslint-plugin-sonarjs)</summary> ### [`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...004d7944672f249000e1eb1c97acd13e31e455eb) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3) ### [`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2) #### What's Changed - Export "meta" for plugin by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#472 ### [`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0) [Compare Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0) Eslint-plugin-sonarjs is compatible with ESLint v9. ##### What's Changed - Migrate to all newest packages, except for eslint v9 by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#460 - Move from a compile-all to a compile-entry-point pattern by [@​ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#463 - ESLINTJS-36 Split out tests and analyze into separate steps by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#465 - Fix breaking no-one-iteration-loop after ESLint v9 breaking change by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#467 - Resolve ESLINTJS-37 by [@​ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#466 - Add ruling tests to handle eslint 8 and 9 by [@​zglicz](https://togithub.com/zglicz) in [SonarSource/eslint-plugin-sonarjs#468 - Make the exported rules a typed record by [@​ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource) in [SonarSource/eslint-plugin-sonarjs#469 **Full Changelog**: SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ScaleLeap/amazon-marketplaces). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsicmVub3ZhdGVib3QiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ESLINTJS-45
In this MR, we allow for the ruling tests to be agnostic of ESLint version and this allows us to perform the tests on Eslint 8 and 9. All green!