Add additional On Manual Interaction Required notifications #6450
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,6 +96,17 @@ public void Check(TrackedDownload trackedDownload) | |||
| if (series == null) | |||
| { | |||
| trackedDownload.Warn("Series title mismatch; automatic import is not possible. Check the download troubleshooting entry on the wiki for common causes."); | |||
|
|
|||
| if (!trackedDownload.HasNotifiedManualInteractionRequired) | |||
There was a problem hiding this comment.
Do you think might be worth the trouble to check if release source is not interactive search? 🤔
There was a problem hiding this comment.
you mean in this case don't notify if it was an interactive search, with the expectation that user is already present and ready to import?
There was a problem hiding this comment.
Yes, exactly. This logic is already applied a few lines below this.
There was a problem hiding this comment.
I'm not sure I agree here. I this case it would stop all warnings when the title was a mismatch. I didn't change the logic here of the warning creation, only added the notifcation
markus101
requested changes
Jan 31, 2024
markus101
reviewed
Feb 1, 2024
markus101
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trigger notification on other manual interaction types.
Issues Fixed or Closed by this PR