Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dokka documentation to artifacts #141

Merged
merged 7 commits into from
Apr 22, 2022

Conversation

tripolkaandrey
Copy link
Contributor

@tripolkaandrey tripolkaandrey commented Apr 22, 2022

This PR adds Dokka-generated documentation as a publish artifact.

It is done by using functionality introduced in this PR in config.

Also, while updating the config, the dead code from buildSrc, like the groovy directory, was removed.

Important details

Breaking changes were introduced in the 2.11.0 version of error_prone_core leading to a compilation error. The 2.10.0 version was forced for all other Error Prone parts to resolve the issue.

@tripolkaandrey tripolkaandrey self-assigned this Apr 22, 2022
@tripolkaandrey tripolkaandrey marked this pull request as draft April 22, 2022 15:32
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #141 (faaf3b7) into master (70a52eb) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
- Coverage     94.73%   94.61%   -0.12%     
+ Complexity      342      341       -1     
============================================
  Files            52       52              
  Lines           892      892              
  Branches         18       18              
============================================
- Hits            845      844       -1     
  Misses           43       43              
- Partials          4        5       +1     

pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@tripolkaandrey
Copy link
Contributor Author

Vulnerabilities regarding Dokka dependencies can be fixed only by adding dependency constraints in the config repository because they originated from transitive dependencies of the precompiled script dokka-for-java.

The vulnerability of error_prone_core is not relevant as this dependency is forced to 2.10.0 which uses 30.1-jre with no mentioned vulnerabilities.

@tripolkaandrey tripolkaandrey marked this pull request as ready for review April 22, 2022 15:49
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tripolkaandrey tripolkaandrey merged commit bd99aaf into master Apr 22, 2022
@tripolkaandrey tripolkaandrey deleted the add-dokka-documentation-to-artifacts branch April 27, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants