Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop duplicated dependencies from pom.xml #182

Merged
merged 10 commits into from
May 4, 2022

Conversation

yevhenii-nadtochii
Copy link
Contributor

@yevhenii-nadtochii yevhenii-nadtochii commented May 3, 2022

This PR addresses #362.

In particular, it does the following:

  1. Deletes manual applying of pmd plugin, which is now applied via our pmd-settings script. It eliminates duplicated dependencies on pmd.
  2. Pulls the latest config which contains a fix for the issue. It hides duplicated dependencies on protoc, emitting a warning.
  3. Enables publication of dokkaJar artifact.

Additionally, J2ObjC.lib was replaced with J2ObjC.annotations, as the former is deprecated:

    const val annotations = "com.google.j2objc:j2objc-annotations:${version}"
    @Deprecated("Please use `annotations` instead.", ReplaceWith("annotations"))
    const val lib = annotations

Please note, when pulling the latest config, the versions of some libraries have been preserved as they were:

  1. ErrorProne kept 2.10.0 due to Bump the versions of Spine libraries #181.
  2. CommonsCli kept 1.4.0 due to Bump the versions of Spine libraries #181.
  3. Protobuf kept 3.19.4 due to Bump the version of Protobuf #183.

The library version is bumped to 2.0.0-SNAPSHOT.74.

@yevhenii-nadtochii yevhenii-nadtochii self-assigned this May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #182 (0445b0b) into master (962feef) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #182   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity      232      232           
=========================================
  Files            77       77           
  Lines          2327     2327           
  Branches         48       48           
=========================================
  Hits           1506     1506           
  Misses          803      803           
  Partials         18       18           

@yevhenii-nadtochii yevhenii-nadtochii marked this pull request as ready for review May 4, 2022 10:15
@yevhenii-nadtochii
Copy link
Contributor Author

@armiol Please take a look.

Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the memory consumption. Also, we need to check if the published documentation is fine. You may publish this locally to inspect the artifacts.

pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@yevhenii-nadtochii
Copy link
Contributor Author

@armiol PTAL

Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yevhenii-nadtochii yevhenii-nadtochii merged commit 27aef68 into master May 4, 2022
@yevhenii-nadtochii yevhenii-nadtochii deleted the drop-duplicates-pom branch May 4, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants