Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurate 3.7 #836

Draft
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented May 14, 2020

Started revising the docs for 3.7. Mostly minor changes to change out deprecated method names, but a few structural changes as well.

I'll keep this as a draft for now, to be finalized after the SpongePowered/Sponge#2603 update PR is merged and Configurate 3.8 has a full release, but feel free to drop any thoughts or complaints here as they come up.

the default :javadoc:`TypeSerializerCollection` or locally, by specifying it in the :javadoc:`ConfigurationOptions`
when loading your config.
This ``TypeSerializer`` must then be registered with Configurate. This can be done by specifying it in the :javadoc:`ConfigurationOptions`
when loading your config. In the past, global registration has been supported, but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something missing behind but?

@@ -173,13 +161,20 @@ constructor to instantiate a new object before filling in the annotated fields.

You can also have fields that are not are not annotated with ``@Setting`` in your ``@ConfigSerializable`` classes.
These fields won't be persisted to config files and can be used to store temporary references for your plugin.
For better compatility with future versions of the ObjectMapper, these changes should be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something missing behind be?

@ST-DDT ST-DDT added the API not ready The API/code is not yet ready so we cannot merge this in yet label May 14, 2020
@Spongy
Copy link

Spongy commented May 14, 2020

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/66f4419/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

@Inscrutable Inscrutable added this to the v7.X milestone May 15, 2020
@Inscrutable
Copy link
Member

Bump. What's the likelihood of finishing this soon @zml2008 ?

@zml2008
Copy link
Member Author

zml2008 commented Jan 30, 2021

uhhh, it's not impossible, but it is one of quite a few things on my plate at the moment so progress is uncertain

@Inscrutable Inscrutable added the FLARD This is gathering dust label Jul 8, 2021
@Inscrutable
Copy link
Member

This is your annual issue bump @zml2008

@Inscrutable
Copy link
Member

This PR is about to have it's third birthday. Hi @zml2008 want some cake?

@Inscrutable
Copy link
Member

Happy Birthday toooo yoooooouuuuuuu 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API not ready The API/code is not yet ready so we cannot merge this in yet FLARD This is gathering dust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants