Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache steps #1097

Merged
merged 4 commits into from
Mar 28, 2021
Merged

Add cache steps #1097

merged 4 commits into from
Mar 28, 2021

Conversation

cdhunt
Copy link
Contributor

@cdhunt cdhunt commented Mar 19, 2021

No description provided.

@cdhunt
Copy link
Contributor Author

cdhunt commented Mar 19, 2021

The cache step does eliminate the redundant module downloads but doesn't noticeably improve the workflow runtime.

@tlimoncelli tlimoncelli merged commit b081ba1 into master Mar 28, 2021
@tlimoncelli tlimoncelli deleted the chunt_buidcache branch March 28, 2021 17:41
@jauderho
Copy link
Contributor

IIRC, there's a bug with the caching where the cache increases until it hits the max. See docker/build-push-action#252 (comment)

This is how I fixed it for my Docker builds. https://github.com/jauderho/dockerfiles/blob/main/.github/workflows/cloudflared.yml

I'll see if I can find some time to test out a similar fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants