Merge pull request #201 from StackStorm/fix-tests

Fix tests
StackStorm · Apr 11, 2020 · ef3f96f · ef3f96f
2 parents 5a75bef + 3b9f429
commit ef3f96f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
   "main": "index.js",
   "scripts": {
     "eslint": "eslint .",
-    "test": "nyc mocha"
+    "test": "nyc mocha --exit"
   },
   "nyc": {
     "temp-directory": "./coverage/.nyc_output",

diff --git a/test/test-formatdata.js b/test/test-formatdata.js
@@ -395,7 +395,7 @@ describe('SparkFormatter', function() {
     var msg = {
       message: {
         user: {
-          room: "SparkRoomName",
+          roomId: "SparkRoomId",
           name: "SparkUserName"
         }
       }
@@ -404,7 +404,7 @@ describe('SparkFormatter', function() {
     expect(o.name).to.be.an('string');
     expect(o.name).to.equal('SparkUserName');
     expect(o.room).to.be.an('string');
-    expect(o.room).to.equal('SparkRoomName');
+    expect(o.room).to.equal('SparkRoomId');
   });
 });
 

diff --git a/test/test-postdata.js b/test/test-postdata.js
@@ -902,7 +902,9 @@ describe("spark post data", function() {
     expect(robot.messageRoom).to.have.been.calledOnce;
     expect(robot.messageRoom).to.have.been.calledWith(
       {
-        channel: input.channel,
+        id: input.channel,
+        roomId: input.channel,
+        name: input.user,
         extra: undefined
       },
       user + "normal boring text"
@@ -912,6 +914,7 @@ describe("spark post data", function() {
   it('should post to room and not mention a user', function() {
     robot.messageRoom = sinon.spy();
     var input = {
+      user: 'stanley',
       channel: '#stackstorm',
       message: "normal boring text",
       whisper: false
@@ -922,10 +925,12 @@ describe("spark post data", function() {
     expect(robot.messageRoom).to.have.been.calledOnce;
     expect(robot.messageRoom).to.have.been.calledWith(
       {
-        channel: input.channel,
+        id: input.channel,
+        roomId: input.channel,
+        name: input.user,
         extra: undefined
       },
-      "normal boring text"
+      "stanley: normal boring text"
     );
   });
 
@@ -947,7 +952,9 @@ describe("spark post data", function() {
     expect(robot.messageRoom).to.have.been.calledOnce;
     expect(robot.messageRoom).to.have.been.calledWith(
       {
-        channel: input.channel,
+        id: input.channel,
+        roomId: input.channel,
+        name: input.user,
         extra: {
           custom1: "attribute1",
           custom2: "attribute2"
@@ -992,7 +999,9 @@ describe("spark post data", function() {
     expect(robot.messageRoom).to.have.been.calledOnce;
     expect(robot.messageRoom).to.have.been.calledWith(
       {
-        channel: input.channel,
+        id: input.channel,
+        roomId: input.channel,
+        name: input.user,
         extra: undefined
       },
       user + "NORMAL PRETEXT\nnormal boring text"