Mark more grpc error codes as recoverable errors. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When CANCELED is returned, the operation was cancelled. Mark the error as recoverable and allows the Client to resend the samples. - When DEADLINE_EXCEEDED is returned, the operation might not be completed. Mark the error as recoverable and allows the Client to resend the samples. - When PERMISSION_DENIED or UNAUTHENTICATED errors are returned, it's the errors are not caused by the samples - so we mark the errors as recoverable errors and allows the Client to resend the samples until the permission and authentication are fixed.
jkohen
reviewed
Sep 30, 2019
There was a problem hiding this comment.
@StevenYCChou your analysis of why these errors happen is correct. These errors are generally accepted to be permanent. Can you explain the reason to make them retriable? What does it mean to the application? I want to make sure we are not working around a problem elsewhere.
Let's talk in person if it's easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error as recoverable and allows the Client to resend the samples.
completed. Mark the error as recoverable and allows the Client to
resend the samples.
the errors are not caused by the samples - so we mark the errors as
recoverable errors and allows the Client to resend the samples until
the permission and authentication are fixed.