Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bevy 0.8 #205

Closed
wants to merge 4 commits into from
Closed

Update to Bevy 0.8 #205

wants to merge 4 commits into from

Conversation

neocturne
Copy link
Contributor

This updates all Rust and shader code to work with Bevy 0.8. All examples seem to work fine on my system (Linux Wayland, tested with --features bevy/wayland because of bevyengine/bevy#5524).

@StarArawn
Copy link
Owner

What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug.

@neocturne
Copy link
Contributor Author

What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug.

Interesting, do you have a link to a bug report?

It seems to work on my machine with Vulkan (as mentioned, I'm on Linux/Wayland):

AdapterInfo { name: "AMD RADV RENOIR", vendor: 4098, device: 5686, device_type: IntegratedGpu, backend: Vulkan }

Apply minimal changes to make Rust and shader code compile with Bevy 0.8.
Run `cargo update` to update all dependencies to the latest compatible
version.
As crevice has been replaced with encase, we can now take care of the
min_binding_size TODO.
The View struct definition had significantly deviated from the local
copy in tilemap[-atlas].wgsl even before Bevy 0.8 and only ever worked
because nothing except for the first field was accessed. Use an #import
to ensure that we always get the correct defintion from Bevy itself.
@StarArawn
Copy link
Owner

What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug.

Interesting, do you have a link to a bug report?

It seems to work on my machine with Vulkan (as mentioned, I'm on Linux/Wayland):

AdapterInfo { name: "AMD RADV RENOIR", vendor: 4098, device: 5686, device_type: IntegratedGpu, backend: Vulkan }

Huh, it might be a windows only thing. Here is the issue I uncovered:
gfx-rs/naga#2018

I tested this branch specifically and it does not work for me in windows 11, vulkan, and geforce driver 511.79. Dx12 works however.

@mbolt35
Copy link
Contributor

mbolt35 commented Aug 3, 2022

Tested this on Windows 10 with Vulkan backend:

AdapterInfo { name: "NVIDIA GeForce RTX 2070", vendor: 4318, device: 7956, device_type: DiscreteGpu, backend: Vulkan }

Works great, no issues so far.

@StarArawn
Copy link
Owner

Tested this on Windows 10 with Vulkan backend:

AdapterInfo { name: "NVIDIA GeForce RTX 2070", vendor: 4318, device: 7956, device_type: DiscreteGpu, backend: Vulkan }

Works great, no issues so far.

Yeah, I discovered the issue was due to a driver bug. Updating my drivers resolved the issue. I likely still wont merge this as we are fairly close to merging the rewrite branch into master and releasing a new version.

@mbolt35
Copy link
Contributor

mbolt35 commented Aug 3, 2022

Yeah, I discovered the issue was due to a driver bug. Updating my drivers resolved the issue. I likely still wont merge this as we are fairly close to merging the rewrite branch into master and releasing a new version.

Awesome! Looking forward to the changes in rewrite. Just to confirm, the rewrite branch has support for bevy 0.8?

@StarArawn
Copy link
Owner

Awesome! Looking forward to the changes in rewrite. Just to confirm, the rewrite branch has support for bevy 0.8?

Correct! Most of the work is done for the rewrite. I'm mostly working on cleaning up docs.

@StarArawn StarArawn mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants