Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix possible NPE in collecting mv metrics #45583

Merged
merged 1 commit into from
May 15, 2024
Merged

[BugFix] Fix possible NPE in collecting mv metrics #45583

merged 1 commit into from
May 15, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented May 14, 2024 •
edited

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing
Fix possible NPE in collecting mv metrics
e7e83b6 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing LiShuMing requested review from a team as code owners May 14, 2024 06:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 4 / 9 (44.44%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/http/BaseAction.java 0 1 00.00% [108]
🔵 com/starrocks/metric/MaterializedViewMetricsRegistry.java 1 5 20.00% [73, 78, 79, 80]
🔵 com/starrocks/metric/MaterializedViewMetricsEntity.java 3 3 100.00% []

@kangkaisen kangkaisen merged commit 0f035fd into StarRocks:main May 15, 2024
58 of 62 checks passed
@LiShuMing
Copy link
Contributor Author

@mergify backport branch-3.2

@LiShuMing
Copy link
Contributor Author

@mergify backport branch-3.3

@github-actions github-actions bot added the 3.3 label May 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024 •
edited

backport branch-3.3

✅ Backports have been created

@github-actions github-actions bot added the 3.2 label May 16, 2024
mergify bot pushed a commit that referenced this pull request May 16, 2024
@LiShuMing @mergify
[BugFix] Fix possible NPE in collecting mv metrics (#45583)
e85a90a 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 0f035fd)
@mergify mergify bot mentioned this pull request May 16, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request May 16, 2024
@LiShuMing @mergify
[BugFix] Fix possible NPE in collecting mv metrics (#45583)
bbe16f7 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 0f035fd)
@mergify mergify bot mentioned this pull request May 16, 2024
Merged
42 tasks
@LiShuMing
Copy link
Contributor Author

@mergify backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2024 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2024
@LiShuMing @mergify
[BugFix] Fix possible NPE in collecting mv metrics (#45583)
fd3a4cc 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 0f035fd)
@mergify mergify bot mentioned this pull request May 16, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request May 16, 2024
@mergify @LiShuMing
[BugFix] Fix possible NPE in collecting mv metrics (backport #45583) (#…
4964291 
…45755)

Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @LiShuMing
[BugFix] Fix possible NPE in collecting mv metrics (backport #45583) (#…
415850c 
…45754)

Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 17, 2024
@mergify @LiShuMing
[BugFix] Fix possible NPE in collecting mv metrics (backport #45583) (#…
905a759 
…45758)

Co-authored-by: shuming.li <ming.moriarty@gmail.com>
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
@LiShuMing @node
[BugFix] Fix possible NPE in collecting mv metrics (StarRocks#45583)
c4547d6 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@mofeiatwork mofeiatwork mofeiatwork approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.1-merged 3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LiShuMing @kangkaisen @mofeiatwork