Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Empty hash table support lazy materialize join #45589

Merged
merged 4 commits into from
May 15, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented May 14, 2024

Why I'm doing:

The 4th pr for lazy materialized join.

Empty hash table support lazy materialize join.

What I'm doing:

Empty hash table support lazy materialize join.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.3 label May 14, 2024
Signed-off-by: trueeyu <lxhhust350@qq.com>
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu marked this pull request as ready for review May 14, 2024 11:16
@trueeyu trueeyu requested a review from a team as a code owner May 14, 2024 11:16
Signed-off-by: trueeyu <lxhhust350@qq.com>
satanson
satanson previously approved these changes May 15, 2024
Signed-off-by: trueeyu <lxhhust350@qq.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 41 / 48 (85.42%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/join_hash_map.tpp 0 1 00.00% [1404]
🔵 be/src/exec/join_hash_map.h 41 47 87.23% [605, 606, 607, 615, 616, 617]

@trueeyu trueeyu merged commit 3092cc5 into StarRocks:main May 15, 2024
46 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 15, 2024
Copy link
Contributor

mergify bot commented May 15, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 15, 2024
Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 3092cc5)
wanpengfei-git pushed a commit that referenced this pull request May 16, 2024
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants