[BugFix] Fix ColumnId empty bug when upgrading #45594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueeyu
previously approved these changes
May 14, 2024
HangyuanLiu
previously approved these changes
May 14, 2024
|
HangyuanLiu
approved these changes
May 15, 2024
nshangyiming
approved these changes
May 15, 2024
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
node
pushed a commit
to vivo/starrocks
that referenced
this pull request
May 17, 2024
## Why I'm doing: Introduced by StarRocks#45364 The default value of columnId is set to empty in `Column()`, which will cause the logic in `gsonPostProcess()` not to be executed during the upgrade. Signed-off-by: gengjun-git <gengjun@starrocks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Introduced by #45364
The default value of columnId is set to empty in
Column(), which will cause the logic ingsonPostProcess()not to be executed during the upgrade.What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: