Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix wrong result when enable lake_tablet_internal_parallel #45599

Merged
merged 1 commit into from
May 22, 2024

Conversation

smartlxh
Copy link
Contributor

@smartlxh smartlxh commented May 14, 2024

Why I'm doing:

The query may lost data when enable lake_tablet_internal_paralleland data skew happens between tablets.

Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/7319

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: smartlxh <smartlxh@gmail.com>
@smartlxh smartlxh requested review from a team as code owners May 14, 2024 10:57
@github-actions github-actions bot added the 3.3 label May 14, 2024
@sduzh
Copy link
Contributor

sduzh commented May 14, 2024

Could you please give a more detailed explanation of the problem? Also, it would be better to add a test.

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/tablet_reader.cpp 0 1 00.00% [125]

@imay imay merged commit 0e38d69 into StarRocks:main May 22, 2024
63 of 68 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 22, 2024
Copy link
Contributor

mergify bot commented May 22, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 22, 2024
@smartlxh smartlxh deleted the fix_tablet_parallel branch May 22, 2024 05:09
wanpengfei-git pushed a commit that referenced this pull request May 22, 2024
…backport #45599) (#46057)

Co-authored-by: fgump <smartlxh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants