Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support execute-only flag for performance test #45601

Merged
merged 2 commits into from
May 15, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented May 14, 2024

Why I'm doing:

What I'm doing:

don't send sql result to client, for test accurate performance

MySQL td> set enable_execution_only=false
Query OK, 0 rows affected
Time: 0.021s
MySQL td> select * from t1;
+--------+--------+-----------+
| v1     | v2     | a1        |
+--------+--------+-----------+
| <null> | <null> | ["a"]     |
| 1      | 1      | ["1","2"] |
| 1      | <null> | []        |
| 2      | 2      | ["3","4"] |
| 2      | <null> | []        |
| 3      | <null> | []        |
| 4      | <null> | []        |
| 5      | <null> | <null>    |
+--------+--------+-----------+
8 rows in set
Time: 0.099s
MySQL td> set enable_execution_only=true
Query OK, 0 rows affected
Time: 0.004s
MySQL td> select * from t1;
+----+----+----+
| v1 | v2 | a1 |
+----+----+----+
+----+----+----+
0 rows in set
Time: 0.059s
MySQL td>

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Seaven <seaven_7@qq.com>
Signed-off-by: Seaven <seaven_7@qq.com>
@mergify mergify bot assigned Seaven May 14, 2024
Copy link

sonarcloud bot commented May 14, 2024

Copy link

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 2 2 100.00% []
🔵 com/starrocks/qe/StmtExecutor.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 9128411 into StarRocks:main May 15, 2024
62 of 65 checks passed
node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants