Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support set_var hint for DML (backport #35283) #45602

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 14, 2024

Why I'm doing:

  • The SET_VAR hint is only viable for query, but not DML

What I'm doing:

  • Support set_var for insert/update/delete sql

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #35283 done by [Mergify](https://mergify.com). Why I'm doing: - The `SET_VAR` hint is only viable for query, but not DML

What I'm doing:

  • Support set_var for insert/update/delete sql

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit cc2e5ad)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
@mergify mergify bot added the conflicts label May 14, 2024
@mergify mergify bot requested a review from a team as a code owner May 14, 2024 11:22
Copy link
Contributor Author

mergify bot commented May 14, 2024

Cherry-pick of cc2e5ad has failed:

On branch mergify/bp/branch-3.1/pr-35283
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit cc2e5ad571.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/ast/DmlStmt.java
	new file:   fe/fe-core/src/test/java/com/starrocks/sql/plan/SetVarTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request May 14, 2024
22 tasks
@wanpengfei-git wanpengfei-git requested a review from a team May 14, 2024 11:22
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 14, 2024 11:22
@mergify mergify bot closed this May 14, 2024
Copy link
Contributor Author

mergify bot commented May 14, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled May 14, 2024 11:22

Pull request was closed

@LiShuMing LiShuMing reopened this May 14, 2024
@LiShuMing LiShuMing closed this May 14, 2024
@LiShuMing LiShuMing reopened this May 14, 2024
@mofeiatwork mofeiatwork removed their assignment May 14, 2024
@LiShuMing LiShuMing closed this May 16, 2024
@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-35283 branch May 16, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants