-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] pushdown or predicate (7): support bitmap filter #45603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… predicate Signed-off-by: zihe.liu <ziheliu1024@gmail.com> bitmap Signed-off-by: zihe.liu <ziheliu1024@gmail.com> s Signed-off-by: zihe.liu <ziheliu1024@gmail.com> bitmap Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
ZiheLiu
changed the title
[Enhancement] pushdown or predicate (8): support bitmap filter
[Enhancement] pushdown or predicate (7): support bitmap filter
May 14, 2024
ZiheLiu
force-pushed
the
feat/main/or_pred_7_bitmap
branch
from
May 20, 2024 08:07
8b3fb7f
to
3c8854a
Compare
ZiheLiu
force-pushed
the
feat/main/or_pred_7_bitmap
branch
from
May 20, 2024 12:48
d769957
to
651a3fd
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 293 / 309 (94.82%) file detail
|
kangkaisen
approved these changes
May 22, 2024
satanson
approved these changes
May 22, 2024
Seaven
approved these changes
May 22, 2024
wyb
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Support bitmap filter for OR predicates.
What I'm doing:
The status for a predicate to apply bitmap index contains 4 kinds:
NOT_USED
: cannot apply bitmap index.ALWAYS_TRUE
: the predicate always returns true, eg.c1 in (1, 2, 3)
and bitmap index also only contains(1, 2, 3)
.ALWAYS_FALSE
: the predicate always returns false, eg.c1 in (1, 2, 3)
and bitmap index does not contain any of1, 2, 3
.OK
: the predicate can apply bitmap index and does not always return true or false, that is , need to evaluate with bitmap index data.AND
andOR
deal with each status in different ways:NOT_USED
AND
:NOT_USED
child predicate, use them to apply bitmap index.NOT_USED
child predicate, returnNOT_USED
.OR
:NOT_USED
child predicate, returnNOT_USED
.ALWAYS_TRUE
AND
:ALWAYS_TRUE
child predicates.ALWAYS_TRUE
child predicate, returnALWAYS_TRUE
.OR
:ALWAYS_TRUE
predicate, returnALWAYS_TRUE
.ALWAYS_FALSE
AND
:ALWAYS_FALSE
predicate, returnALWAYS_FALSE
.OR
:ALWAYS_FALSE
child predicates.ALWAYS_FALSE
child predicate, returnALWAYS_FALSE
.OK
AND
andOR
usesOK
child predicates to apply bitmap index.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: