Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] make the default mv task as manual (backport #45322) #45619

Merged
merged 1 commit into from
May 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 14, 2024

Why I'm doing:

  • These's a difference between MANUAL and PERIODICAL task in the scope of MV
    • MANUAL: REFRESH MATERIALIZED VIEW command, would refresh all partitions regardless of auto_refresh_partitions_limit
    • PERIODICAL: auto refresh, would consider the auto_refresh_partitions_limit
  • After creating MV
    • will create a refresh task, which should be the MANUAL task, instead of PERIODICAL task.
    • so, the MV would be completed refreshed regardless of auto_refresh_partitions_limit

What I'm doing:

  • So we need to change the default task type to MANUAL

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #45322 done by [Mergify](https://mergify.com). ## Why I'm doing: - These's a difference between `MANUAL` and `PERIODICAL` task in the scope of MV - MANUAL: `REFRESH MATERIALIZED VIEW` command, would refresh all partitions regardless of `auto_refresh_partitions_limit` - PERIODICAL: auto refresh, would consider the `auto_refresh_partitions_limit` - After creating MV - will create a refresh task, which should be the `MANUAL` task, instead of `PERIODICAL` task. - so, the MV would be completed refreshed regardless of `auto_refresh_partitions_limit`

What I'm doing:

  • So we need to change the default task type to MANUAL

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit ba938ff)
Copy link

sonarcloud bot commented May 14, 2024

@wanpengfei-git wanpengfei-git merged commit 67b1dd8 into branch-3.3 May 16, 2024
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-45322 branch May 16, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants