Handle completed tasks in ApmAsyncFactory. #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #281.
I couldn't really find documentation on how to handle sync operations in APM. I tested various options, and it seems the
IAsyncResult
response should have theCompletedSynchronously
set totrue
to indicate that this is a sync flow. In that case, we're not obliged to call the callback, and that's exactly what we need. But, the Task has a hard-codedfalse
value for this property, so returning Task will never work in this scenario. I just ended up using a new internal typeCompletedAsyncResult
for this scenario.This fixes all issues, at least the usages I can think of.