-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to get systemName as reported by OpenXR #563
base: develop
Are you sure you want to change the base?
Conversation
Btw, this adds |
I do have a branch with this functionality in it! I was considering this to be part of a |
I guess so. I really just need the headset type name through some API. |
I did ship |
Edit 2: the below turns out to be an issue unrelated to the new Is there a specific context in which
With an x64 build on UWP I get Log output:
I had the Oculus runtime installed, but just removed it to see if that was interfering. Normally, a run would just drop into the simulator, but something seems to go wrong now. |
Not directly related to StereoKit itself, but I see that on HoloLens 2 the |
Device.Name on UWP simulator might have a bug? I'll peek at that! Device.Name is likely going to be somewhat generic on some runtimes! I don't believe I've seen WMR report anything else, but I think Oculus gives a bit more detail in this field. OpenXR has always been about reporting capabilities and not platforms, so it could be a somewhat philosophical decision on their part to not be more specific! |
I ran into #343 (floor height inconsistent between devices) again and would really like to be able to do a check at startup to handle different systems. I suspect OpenXR's systemName property isn't always useful, but in my case I can see "XR-3" being reported in the SK initialization, so I can definitely detect that and use it in those cases (probably other headsets as well).