Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup (db, email, admin, etc) #681

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

knownasilya
Copy link
Member

WIP, don't merge.

Basically a rough start on an initial setup page if no users exist.

TODO

  • Integrate https://github.com/mgonto/angular-wizard
  • Hookup form data to controller
  • Add an endpoint for processing a setup request
  • Save some of the settings in a config file
  • Figure out which settings need to be there
    • Add proxy settings
  • Cleanup existing config init

@knownasilya
Copy link
Member Author

@keyvanfatehi @niallo how should I save the config? Use .striderrc (from the rc package), or store it in the db as the default config but over writable?

@niallo
Copy link
Member

niallo commented Feb 22, 2015

I'd suggest DB

On Saturday, February 21, 2015, Ilya Radchenko notifications@github.com
wrote:

@keyvanfatehi https://github.com/keyvanfatehi @niallo
https://github.com/niallo how should I save the config? Use .striderrc
(from the rc package), or store it in the db as the default config but over
writable?


Reply to this email directly or view it on GitHub
#681 (comment).

Niall O'Higgins
W: http://niallohiggins.com
E: n@niallo.me
T: @niallohiggins

@knownasilya
Copy link
Member Author

@niallo I went with the config, since there is only one config and it's not associated with the user. I think it would be a waste to put it in the db. Also it would be much easier to tweak if needed.

Just wondering what configs should be here, currently I have the smtp, admin user, and server_name. I'm thinking maybe adding provider config as well, so github, bitbucket, heroku, etc.

@niallo
Copy link
Member

niallo commented Feb 24, 2015

The only thing about a file is a stateless environment like docker. Need to
make sure that state is saved properly, or people will be really confused.
Folks likely already have their DB set up to persist, but may not for
strider itself.

So we'll need to make sure that people know that strider will need to save
$HOME/.striderrc

Provider configs would also be nice, yeah, since that's pretty much the
first thing you need to set up.

Cheers.

On Tuesday, February 24, 2015, Ilya Radchenko notifications@github.com
wrote:

@niallo https://github.com/niallo I went with the config, since there
is only one config and it's not associated with the user. I think it would
be a waste to put it in the db. Also it would be much easier to tweak if
needed.

Just wondering what configs should be here, currently I have the smtp,
admin user, and server_name. U'm thinking maybe adding provider config as
well, so github, bitbucket, heroku


Reply to this email directly or view it on GitHub
#681 (comment).

Niall O'Higgins
W: http://niallohiggins.com
E: n@niallo.me
T: @niallohiggins

@knownasilya
Copy link
Member Author

Good point.. hum I guess the db might have to be used..

@knownasilya knownasilya force-pushed the initial-setup branch 2 times, most recently from 78a7f0b to 4e466df Compare April 21, 2015 20:36
@knownasilya knownasilya added this to the v1.7.0 milestone Apr 28, 2015
@knownasilya knownasilya self-assigned this Apr 28, 2015
@oliversalzburg
Copy link
Member

I'm not sure if it's too early to mention this, but I think it would be great if only the bare minimum of strider plugins are declared in package.json and, during the setup phase, the user can chose which plugins he wants.

@knownasilya
Copy link
Member Author

Yeah that is a good idea, maybe we could just send them to the plugin manager right after setup.

@knownasilya knownasilya removed this from the v1.8.0 milestone Mar 14, 2017
@michaelmior michaelmior force-pushed the master branch 3 times, most recently from 6b0e7b4 to 41a7127 Compare July 19, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants