-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profiling step functions #886
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Unsure about how the mocks are (re)defined in this PR, I feel like it's contrary to best practices.
Also need a rebase ^^
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
…o `orchestrator` Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
0887c24
to
115f0aa
Compare
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
…ator_client` Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work 🙏
Description
Allow transferring function profiling steps through the orchestrator, allowing the builder to register event without having to have http(s) requests to the backend api server (involving having access to the db to get credentials). This also allows having duration for the function available on every backend.
Still open on naming for the two new steps for the function. For now we have:
This does not include the API part for the frontend, which woudl be part of another task (FL-1518)
Fixes FL-1519
Companion PR
How has this been tested?
Checklist