chore: resources in separate yaml #903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
58
to
61
| try: | ||
| requests = resources_dict["requests"] | ||
| except KeyError: | ||
| requests = None |
There was a problem hiding this comment.
Suggested change
| try: | |
| requests = resources_dict["requests"] | |
| except KeyError: | |
| requests = None | |
| requests = resources_dict.get("requests", None) |
Comment on lines
63
to
66
| try: | ||
| limits = resources_dict["limits"] | ||
| except KeyError: | ||
| limits = None |
There was a problem hiding this comment.
Suggested change
| try: | |
| limits = resources_dict["limits"] | |
| except KeyError: | |
| limits = None | |
| limits = resources_dict.get("limits", None) |
ThibaultFy
force-pushed
the
requests-in-separate-yaml
branch
from
13951d5
to
e9325ed
Compare
guilhem-barthes
approved these changes
May 16, 2024
thbcmlowk
reviewed
May 16, 2024
| @@ -28,6 +28,7 @@ deploy: | |||
| chartPath: charts/substra-backend | |||
| valuesFiles: | |||
| - examples/values/backend-org-1.yaml | |||
| - charts/substra-backend/resources.yaml | |||
There was a problem hiding this comment.
I am not sure I am following. Is it not prod values that are in the resources.yaml file?
There was a problem hiding this comment.
The values are the ones that we currently apply by default. It is up to us to decide if we put prod values (so with highest requests) or if we want to keep these low requests. Also, il was to test that it was working as expected. We can also completely remove it from skaffold but I don't know how to ensure that this file stay up to date with CI
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
ThibaultFy
force-pushed
the
requests-in-separate-yaml
branch
from
dc145b9
to
eee1ada
Compare
|
close in favor of #907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
part of FL-1562
How has this been tested?
Resources are tested by being injected in org-1 with skaffold
Checklist