feat: add Harbor as a skaffold profile #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SdgJlbl
force-pushed
the
feat/add-harbor-in-skaffold
branch
from
c83d704
to
188411a
Compare
SdgJlbl
force-pushed
the
feat/add-profile-to-launch-harbor-as-external-registry+
branch
from
ab04540
to
8015f7b
Compare
SdgJlbl
force-pushed
the
feat/add-harbor-in-skaffold
branch
from
188411a
to
615f4a8
Compare
guilhem-barthes
approved these changes
May 20, 2024
Base automatically changed from
feat/add-profile-to-launch-harbor-as-external-registry+
to
main
May 21, 2024 07:35
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
SdgJlbl
force-pushed
the
feat/add-harbor-in-skaffold
branch
from
615f4a8
to
e010dc3
Compare
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
|
Tested in all 3 configurations (builder on 1, task on 2; builder on 2, task on 2; builder on 2; task on 1) locally 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Checklist