Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): mark metrics used by Apps #3061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swiatekm-sumo
Copy link
Contributor

I've reviewed all the metrics we test for and marked the ones used in Sumo Apps. Might also be useful to review the application metrics we don't test for, but that can happen in a separate change.

Checklist

  • Changelog updated or skip changelog label added

@andrzej-stencel
Copy link
Contributor

This shows the current state, which is good, but does not give any way to keep this up to date.

@swiatekm-sumo
Copy link
Contributor Author

This shows the current state, which is good, but does not give any way to keep this up to date.

That's definitely not going to happen in this PR. I'm open to representing this information differently, but keeping it up to date is necessarily down to our internal tooling.

@andrzej-stencel
Copy link
Contributor

This shows the current state, which is good, but does not give any way to keep this up to date.

That's definitely not going to happen in this PR. I'm open to representing this information differently, but keeping it up to date is necessarily down to our internal tooling.

It doesn't need to be done in this PR. My point is that if we don't intend to provide an automation to keep this up to date, then I'm not sure if there's much value in putting it there in the first place.

@andrzej-stencel
Copy link
Contributor

As a minimum, can you somehow document how you got this data (and how anyone can do that again to verify the data)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants