-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update the release guide for creating/pushing tags #3127
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to tag a release branch (with major releases), as git hash
is going to give us wrong value if it won't be on main
branch.
This is quite painful and not intuitive that the release branch has already additional commit which is not tagged, but at least CI and builds are being created properly
I didn't think that git hash depended on a branch. Just did a quick search on this and this popped up. A commit hash depends on
As long as we have the correct list of commits in the release branch, it seems like we should be able to push a tag on this branch and create a release, irrespective of major, minor or patch? |
Oh, sorry, I meant
it relies on commits history, so if we tag outside of branch, we always get |
yes that's true, so all the patch release tags would be on the release branch and all the major/minor release tags would go on the |
Yes, exactly |
@rnishtala-sumo can we close it? |
Update the release guide for creating/pushing tags
Release guide change to avoid tags from being created on
main
and instead only create tags on release branches.Documentation updated