New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add schema for values.yaml #3260

Draft

sumo-drosiek wants to merge 1 commit into main from drosiek-create-schema

Contributor

sumo-drosiek commented Sep 12, 2023

Checklist

WIP, so the python code is very bad quality. In final state, only ci/generate_files.py is going to be used. As for now it generates README.md, but I plan to generate values.yaml as well. However I'm not convinced to do it in one PR

github-actions bot added the documentation label

github-actions bot approved these changes

View reviewed changes

sumo-drosiek force-pushed the drosiek-create-schema branch 2 times, most recently from 5ce2662 to f98d1ab Compare

September 13, 2023 13:59

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

Comment on lines 381 to 383

    
                  ## Otel metrics collector. Replaces Prometheus.

                  ## To enable, you need opentelemetry-operator enabled as well.

                  ## Stability: Beta.

Contributor Author

sumo-drosiek Sep 14, 2023

.

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

Comment on lines 605 to 610

    
                #   ## Optionally specify an array of imagePullSecrets.

                #   ## Secrets must be manually created in the namespace.

                #   ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

                #   ##

Contributor Author

sumo-drosiek Sep 14, 2023

.

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

Comment on lines 623 to 627

    
                #   ## Reference to one or more secrets to be used when pulling images

                #   ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

                #   ##

Contributor Author

sumo-drosiek Sep 14, 2023

.

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

Comment on lines 677 to 678

    
                          - expr: "1 - avg by (node) (\n  rate(node_cpu_seconds_total{job=\"node-exporter\"\

                              ,mode=\"idle\"}[1m])\n* on (namespace, pod) group_left(node)\n  node_namespace_pod:kube_pod_info:)"

Contributor Author

sumo-drosiek Sep 14, 2023

would bed nice to have it as multiline string

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

    
            @@ -3494,27 +3299,21 @@ otellogs:
          
                  ## The value of this key should be a dictionary, that will replace the normal configuration.

                  ## This is an advanced feature, use with caution, and review the generated configuration first.

                  override: {}

                ## Set securityContext for containers running in pods in log collector daemonset

Contributor Author

sumo-drosiek Sep 14, 2023

.

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

Comment on lines 3372 to 2075

    
                ## linux:

                ## nodeSelector:

                ## kubernetes.io/os: linux

                ## resources:

                ## limits:

                ## memory: 1Gi

                ## cpu: 6

                ## requests:

                ## memory: 32Mi

                ## cpu: 2

Contributor Author

sumo-drosiek Sep 14, 2023

.

sumo-drosiek commented

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated

Comment on lines 3383 to 2085

    
                ## affinity:

                ## nodeAffinity:

                ## requiredDuringSchedulingIgnoredDuringExecution:

                ## nodeSelectorTerms:

                ## - matchExpressions:

                ## - key: kubernetes.io/os

                ## operator: NotIn

                ## values:

                ## - linux

Contributor Author

sumo-drosiek Sep 14, 2023

.

sumo-drosiek force-pushed the drosiek-create-schema branch 2 times, most recently from 6a322a8 to aa90cf8 Compare

September 21, 2023 15:13

sumo-drosiek force-pushed the drosiek-create-schema branch from aa90cf8 to 29c4433 Compare

November 2, 2023 07:59


          feat: add schema to helm chart

32a7da3

Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>

sumo-drosiek force-pushed the drosiek-create-schema branch from 29c4433 to 32a7da3 Compare

November 2, 2023 08:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment