feat(setup): check if pvcs can be created automatically #3316
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| {{- if .Values.sumologic.setup.dashboards.enabled }} | ||
| can_create_pvc | ||
| {{- end }} |
There was a problem hiding this comment.
Maybe because of waiting, this should be run as a separate process in the background.
aboguszewski-sumo
force-pushed
the
ab-setup-check
branch
2 times, most recently
from
9dce4ba
to
6187cab
Compare
| pvc_test_create_statefulset | ||
| sleep 30 | ||
| pvc_test_check |
There was a problem hiding this comment.
Not sure what constant should be used here.
There was a problem hiding this comment.
do we need to wait 30 seconds? How do we know pvc cannot be created automatically?
There was a problem hiding this comment.
Afaik the only way to do it is to try to create a pvc and see if it gets created - and it doesn't happen automatically. Although it's not perfect, I think it's fine as long as we don't get false negatives (which we might, if creating a pvc takes longer than 30 seconds).
We can lower the impact of waiting by moving this to a separate process, run at the beginning of the script.
|
I'll fix helm template tests once |
| @@ -2,6 +2,57 @@ | |||
|
|
|||
| readonly DEBUG_MODE=${DEBUG_MODE:="false"} | |||
| readonly DEBUG_MODE_ENABLED_FLAG="true" | |||
| readonly TEST_PVC_FILE="test-pvc-ss.yaml" | |||
| readonly TEST_PVC_STATEFULSET="pvc-nginx" | |||
| readonly TEST_PVC_STATEFULSET_CONFIG="apiVersion: v1 | |||
There was a problem hiding this comment.
Is it possible to move it to config map?
There was a problem hiding this comment.
Most env variables are in job.yaml, wouldn't it be better to move it there?
There was a problem hiding this comment.
I was referring to TEST_PVC_STATEFULSET_CONFIG 😅
There was a problem hiding this comment.
I'll have to check how to access it in the setup image.
There was a problem hiding this comment.
I can't find out which files are copied onto the image: https://github.com/SumoLogic/sumologic-kubernetes-setup/blob/main/Dockerfile
There was a problem hiding this comment.
I don't think we need it in image, we can simply use configmap to add it in runtime: https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/deploy/helm/sumologic/templates/setup/configmap.yaml
In dockerfile, we only get files required for terraform init to have dependencies already in image
| function install_kubectl() { | ||
| curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| mkdir -p ~/.local/bin | ||
| mv ./kubectl ~/.local/bin/kubectl | ||
| export PATH=$PATH:~/.local/bin | ||
| } |
There was a problem hiding this comment.
It should be added to setup image
|
When reproducing, I wasn't sure if just creating a pvc will imply whether it can or not be creating automatically - with statefulset I had that guarantee, because it is directly the case we have in the Helm Chart. |
You've seen a situation where a plain PVC worked, but not one created by a StatefulSet? |
|
@swiatekm-sumo It worked when I created PV manually. I had some problems with creating it automatically on EKS (even after adding the plugin), so I went for a statefulset. |
|
I managed to reproduce the problem without using statefulsets: I will remake this then |
aboguszewski-sumo
force-pushed
the
ab-setup-check
branch
from
2ae311e
to
dbde761
Compare
This PR adds to setup script a functionality to check if pvcs can be created automatically.
Checklist