chore: improve diff_values.py #3370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
force-pushed
the
drosiek-fix-diff
branch
2 times, most recently
from
de02c83
to
ca24ea2
Compare
sumo-drosiek
force-pushed
the
drosiek-fix-diff
branch
3 times, most recently
from
b16b9cf
to
9754438
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-fix-diff
branch
from
9754438
to
9c2b084
Compare
Comment on lines
-182
to
+210
| - name: test | ||
| - name: Setup python | ||
| if: needs.scripts-changed.outputs.any_changed == 'true' | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.10" | ||
| - name: test templates | ||
| if: needs.chart-changed.outputs.any_changed == 'true' | ||
| run: make test-templates | ||
| - name: test python scripts | ||
| if: needs.scripts-changed.outputs.any_changed == 'true' | ||
| run: | | ||
| pip install pyyaml | ||
| make test-python-scripts |
There was a problem hiding this comment.
Can we make a separate job for this? I don't want to get test failures because there's something wrong with a helper script we only use for troubleshooting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lists comparison, add regression tests and reformat using black
Checklist