feat(chart): drop kube-prometheus-stack #3561
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm-sumo
commented
Feb 21, 2024
| @@ -311,6 +311,7 @@ If dryRun=true, we do not create any chart labels. | |||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | |||
| release: "{{ .Release.Name }}" | |||
| heritage: "{{ .Release.Service }}" | |||
| app.kubernetes.io/instance: "{{ .Release.Name }}" | |||
There was a problem hiding this comment.
This was added because kube-state-metrics and node-exporter charts don't add the release label to their ServiceMonitors, and I needed a label to select for. In the near future, this shouldn't be necessary, as otel operator will expose more powerful selectors for this.
swiatekm-sumo
force-pushed
the
feat/drop-kube-prometheus-stack
branch
from
5d617a0
to
c9ef9da
Compare
swiatekm-sumo
force-pushed
the
feat/drop-kube-prometheus-stack
branch
from
c9ef9da
to
52b57d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft showing what getting rid of kube-prometheus-stack would look like in practice. Integration tests should pass, template tests should not, as updating them would pollute the diff too much.
Changes:
kube-state-metricsandprometheus-node-exportercharts as direct dependencies. I copied the configuration, as I haven't found anyway to avoid a breaking change here.values.yamlsections, but I'm not sure we want to make this fully configurable.