[v3] deps: update subcharts #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - [Support Matrix](#support-matrix) | ||
| - [ARM support](#arm-support) | ||
| - [Falco support](#falco-support) | ||
| - [Deployment Guide for unreleased version](#deployment-guide-for-unreleased-version) |
There was a problem hiding this comment.
Suggested change
| - [Deployment Guide for unreleased version](#deployment-guide-for-unreleased-version) | |
| - [Deployment Guide for v3](#deployment-guide-for-unreleased-version) |
I would set it to v3 as we are on v3 branch
There was a problem hiding this comment.
It's still an unreleased version though. We don't set it to v4 on main.
There was a problem hiding this comment.
The difference is we do not plan to add anything new to the the branch, otherwise we need to update release.md as well as this line will have to be updated in case of release
There was a problem hiding this comment.
Then we can make this change after we're actually not adding anything to the branch. Right now we're still doing it.
swiatekm-sumo
force-pushed
the
deps/update-dependencies-v3
branch
from
0254ca7
to
ba23bd4
Compare
sumo-drosiek
approved these changes
May 13, 2024
|
Approving, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update subcharts up to what is currently in v4.
Checklist