Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles: sponsor landing page fixes #574

Merged
merged 2 commits into from
May 4, 2024

Conversation

Manice18
Copy link
Contributor

@Manice18 Manice18 commented May 1, 2024

What does this PR do?

closes #573

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Copy link

vercel bot commented May 1, 2024

@Manice18 is attempting to deploy a commit to the Superteam Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
earn ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 8:36pm

@a20hek a20hek changed the title FIX: Sponsor page ui styles: sponsor landing page fixes May 1, 2024
bg="white"
border="0"
rounded="0.25rem"
>
<h2>
<AccordionButton my="1rem" py="0.8rem" rounded="0.25rem">
<AccordionButton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a transition while opening too; currently transition shows up only when closing the accordion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opening transition is not working at all, I tried it for long.
I also tried pasting an example component code from Chakraui's accordion, but the issue persisted there too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try passing props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried all possibilities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that it's an issue in Chakra UI itself:
chakra-ui/chakra-ui#8448

gap={8}
overflow={'scroll'}
maxW={{ base: '100%' }}
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

show a little bit of the 4th testimonial so that someone knows its scrollable – or maybe let the container for testimonials get bigger than the container of the page to fit a bit of the 4th testimonial

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image is this fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but on larger screens, it looks weird
why dont you add an infinite horizontal scroll for them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should keep scrolling on its own

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya got it.

@Manice18
Copy link
Contributor Author

Manice18 commented May 4, 2024

@a20hek can you check now?

@a20hek a20hek merged commit 41608fa into SuperteamDAO:staging May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants