Support complicationset folders #1051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nhancement/complicationset # Conflicts: # CHANGELOG.md
|
I'm not sure if this is the right approach but it works for my use case and passes tests. If there is a better solution please point me in the right direction. |
djbe
requested changes
Mar 15, 2024
There was a problem hiding this comment.
I'm not very familiar with WatchOS complications, but from some quick googling:
- In your project (info.plist), you point it at the right "group" in your asset catalog
- I couldn't find any code samples where users load a complication asset programatically?
So I'm not sure if there's any point in adding support for this type of asset?
Note: also found that all docs mark complications as deprecated, and everything now should be done with WidgetKit. Does that framework also use complicationset assets?
There was a problem hiding this comment.
Do we need to commit all these images? For our other image assets, we simply added 1 variation, which is enough.
Comment on lines
+29
to
+32
| let children = try? folder.children() | ||
| let sorted = children?.sorted(by: <) | ||
|
|
||
| return (sorted?.compactMap { path in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developbranch (gitflow)developas the "base" branch for this Pull Request I'm about to createCHANGELOG.mdfile to explain my changes and credit myself(or added
#trivialto the PR title if I think it doesn't warrant a mention in the CHANGELOG)