Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for visionOS platform #1101

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

shadone
Copy link

@shadone shadone commented Feb 9, 2024

Fixes #1099

@Liquidsoul
Copy link
Member

Hi @shadone and thank you for your contribution.

Could you please update the fixtures related to your changes in the stencils? This can be done by running the command:
bundle exec rake generate:output.

You'll also need to rebase and update the location of your changelog entry.

We may also need to add the new platform to this file, but I do not if this is a good idea because I tried to use arm64-apple-visionos1.0 and it seems that you need to install the visionOS SDK as opposed to other SDKs like tvOS and watchOS.
What I mean is that I do not know if the SDK is installed in the CI and this addition would require anyone who want to run the tests locally to install the visionOS SDK 🤔

@AF-cgi
Copy link

AF-cgi commented Mar 14, 2024

Any updates?

Copy link
Member

@djbe djbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by @Liquidsoul, this PR needs to generate the updated output files, otherwise the tests will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants